Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support build image on multi arch #46

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Support build image on multi arch #46

merged 2 commits into from
Sep 23, 2023

Conversation

drivebyer
Copy link
Collaborator

#43.

@drivebyer drivebyer self-assigned this Sep 23, 2023
@drivebyer drivebyer added the enhancement New feature or request label Sep 23, 2023
@shubham-cmyk
Copy link
Member

shubham-cmyk commented Sep 23, 2023 •
edited
Loading

@drivebyer

Why push is false here?

Maybe we wanted to push the image everytime a PR is merged.

@drivebyer drivebyer changed the title Support build image on multi arch(disable pushing) Support build image on multi arch Sep 23, 2023
@drivebyer
Enable push image
e9f525e 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
Copy link
Collaborator Author

Why push is false here?

Maybe we wanted to push the image everytime a PR is merged.

Fixed

shubham-cmyk
shubham-cmyk approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shubham-cmyk shubham-cmyk merged commit 2a12e8a into OT-CONTAINER-KIT:master Sep 23, 2023
@drivebyer drivebyer deleted the multi-arch branch September 23, 2023 13:42
@shubham-cmyk
Copy link
Member

@drivebyer Well after introducing the qemu the time for building the image has gone really up.
to 2hrs previously it was 8min.

not a big deal right now. But probably in the future, this could be a fix. Right now it works well.

@drivebyer
Copy link
Collaborator Author

@drivebyer Well after introducing the qemu the time for building the image has gone really up. to 2hrs previously it was 8min.

not a big deal right now. But probably in the future, this could be a fix. Right now it works well.

Sure, I will pay attention to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-cmyk shubham-cmyk shubham-cmyk approved these changes

Assignees

@drivebyer drivebyer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drivebyer @shubham-cmyk